[Vimperator] external editor issue and diff

[Gianni Carabelli]

Hi all. I'm new here, tring to fix something that I need (and love) in
vimperator.

The issue:
1. go to a website containing a form with password
2. click on password field and enter "foobar"
3. <C-i>
4. answer "yes"

The editor come up populated with "yes" instead of 'foobar'.

I'm not a javascript expert but the fix could be like in attachment.
Tested (vimperator hg checkout on ubuntu natty)

Tnx

JohnnyRun
-------------- next part --------------
A non-text attachment was scrubbed...
Name: external_yes_no.diff
Type: text/x-patch
Size: 1518 bytes
Desc: not available
URL: <http://www.mozdev.org/pipermail/vimperator/attachments/20120305/61d62687/attachment.bin>

[Rob]

Post by Gianni Carabelli
Hi all. I'm new here, tring to fix something that I need (and love) in
vimperator.
1. go to a website containing a form with password
2. click on password field and enter "foobar"
3. <C-i>
4. answer "yes"
The editor come up populated with "yes" instead of 'foobar'.
I'm not a javascript expert but the fix could be like in attachment.
Tested (vimperator hg checkout on ubuntu natty)

+1
I've found this annoying too, thanks for the fix.
Hope it gets applied quickly

Rob

[Martin Stubenschrott]

Sounds good, I pushed it. Please pay attention to our coding style policy
in future
to keep proper whitespace. (See the HACKING file in the repository).

Thanks for the patch though!

--
Martin

Post by Rob

Post by Gianni Carabelli
Hi all. I'm new here, tring to fix something that I need (and love) in
vimperator.
1. go to a website containing a form with password
2. click on password field and enter "foobar"
3. <C-i>
4. answer "yes"
The editor come up populated with "yes" instead of 'foobar'.
I'm not a javascript expert but the fix could be like in attachment.
Tested (vimperator hg checkout on ubuntu natty)

+1
I've found this annoying too, thanks for the fix.
Hope it gets applied quickly
Rob
_______________________________________________
Vimperator mailing list
Vimperator at mozdev.org
https://www.mozdev.org/mailman/listinfo/vimperator

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mozdev.org/pipermail/vimperator/attachments/20120312/66bec760/attachment.html>

[Gianni Carabelli]

Post by Martin Stubenschrott
Sounds good, I pushed it. Please pay attention to our coding style
policy in future
to keep proper whitespace. (See the HACKING file in the repository).

Ops...sorry.
Next time it will be fine.

JohnnyRun