Discussion:
[Vimperator] [PATCH] refs #584: open, tabopen and spaces
Gianni Carabelli
2012-06-16 15:43:27 UTC
Permalink
One pc of mine is affected by the bug in #584 issue.
I had a look to the comments and wrote only few byte of patch.
I hadn't read all the code there, patched on the fly and it's working
perfectly.


Regards
JohnnyRun



-------------- next part --------------
A non-text attachment was scrubbed...
Name: isdirFixRefs584.patch
Type: text/x-patch
Size: 1064 bytes
Desc: not available
URL: <http://www.mozdev.org/pipermail/vimperator/attachments/20120616/8bf66b82/attachment.bin>
teramako
2012-06-16 21:04:38 UTC
Permalink
Hi

Your patch has a bug.
isdir property always retuns undefined.
Could you rid curly brackets or add 'return' keyword ?
Post by Gianni Carabelli
One pc of mine is affected by the bug in #584 issue.
I had a look to the comments and wrote only few byte of patch.
I hadn't read all the code there, patched on the fly and it's working
perfectly.
Regards
JohnnyRun
Gianni Carabelli
2012-06-17 17:05:01 UTC
Permalink
Post by teramako
Hi
Your patch has a bug.
isdir property always retuns undefined.
Could you rid curly brackets or add 'return' keyword ?
Ops...another silly error for me.
Thanks for the correction.

JohnnyRun
-------------- next part --------------
A non-text attachment was scrubbed...
Name: isdirFixRefs584.patch
Type: text/x-patch
Size: 957 bytes
Desc: not available
URL: <http://www.mozdev.org/pipermail/vimperator/attachments/20120617/3654871b/attachment.bin>
Martin Stubenschrott
2012-06-18 20:49:21 UTC
Permalink
If that fixes the issue 584, that would be perfect.
I guess, we can commit it as there shouldn't be any harm anyway.

On Sun, Jun 17, 2012 at 7:05 PM, Gianni Carabelli
Post by Gianni Carabelli
Post by teramako
Hi
Your patch has a bug.
isdir property always retuns undefined.
Could you rid curly brackets or add 'return' keyword ?
Ops...another silly error for me.
Thanks for the correction.
JohnnyRun
_______________________________________________
Vimperator mailing list
Vimperator at mozdev.org
https://www.mozdev.org/mailman/listinfo/vimperator
Gianni Carabelli
2012-06-19 07:26:06 UTC
Permalink
Post by Martin Stubenschrott
If that fixes the issue 584, that would be perfect.
I guess, we can commit it as there shouldn't be any harm anyway.
If you want a screen record, before and after the "treatment", that's no
problem

JohnnyRun
Martin Stubenschrott
2012-06-19 19:39:19 UTC
Permalink
Nah, I believe you :)

Thanks for the proper fix and I will commit it in the next days when
the 35?C swimming temperatures change to rainy days again :)

Looking for more bug fix patches ;)
Martin

On Tue, Jun 19, 2012 at 9:26 AM, Gianni Carabelli
Post by Gianni Carabelli
Post by Martin Stubenschrott
If that fixes the issue 584, that would be perfect.
I guess, we can commit it as there shouldn't be any harm anyway.
If you want a screen record, before and after the "treatment", that's no
problem
JohnnyRun
_______________________________________________
Vimperator mailing list
Vimperator at mozdev.org
https://www.mozdev.org/mailman/listinfo/vimperator
Martin Stubenschrott
2012-06-24 09:21:33 UTC
Permalink
Sorry it took so long, but now commited.

Thanks again for the patch!

On Tue, Jun 19, 2012 at 9:39 PM, Martin Stubenschrott
Post by Martin Stubenschrott
Nah, I believe you :)
Thanks for the proper fix and I will commit it in the next days when
the 35?C swimming temperatures change to rainy days again :)
Looking for more bug fix patches ;)
Martin
Loading...